Page MenuHomeFreeBSD

acpi: Don't assume a resource is reserved in acpi_delete_resource
ClosedPublic

Authored by jhb on Feb 14 2024, 6:55 PM.
Tags
None
Referenced Files
F102045682: D43891.diff
Wed, Nov 6, 10:36 PM
Unknown Object (File)
Thu, Oct 17, 12:57 AM
Unknown Object (File)
Sun, Oct 13, 9:37 PM
Unknown Object (File)
Sat, Oct 12, 6:42 AM
Unknown Object (File)
Thu, Oct 10, 11:41 PM
Unknown Object (File)
Wed, Oct 9, 2:46 AM
Unknown Object (File)
Oct 7 2024, 8:45 PM
Unknown Object (File)
Oct 5 2024, 1:27 PM
Subscribers

Details

Summary

This fixes a panic if a driver uses bus_set_resource to add a resource
that fails to reserve and then deletes the resource via
bus_delete_resource.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 14 2024, 7:10 PM

I'm surprised this hasn't bitten sooner

In D43891#1001335, @imp wrote:

I'm surprised this hasn't bitten sooner

Very few things use bus_delete_resource. I only hit this when I ran into the ram0 problem and my changes to pci_host_generic caused a bridge to fail to probe when it couldn't allocate its window,