Page MenuHomeFreeBSD

LinuxKPI: 802.11: iwlwifi: add extra debugging
AbandonedPublic

Authored by bz on Feb 14 2024, 3:51 PM.
Tags
None
Referenced Files
F96604947: D43879.diff
Wed, Sep 25, 4:53 PM
Unknown Object (File)
Sun, Sep 22, 10:53 PM
Unknown Object (File)
Wed, Sep 11, 3:00 PM
Unknown Object (File)
Thu, Sep 5, 11:43 AM
Unknown Object (File)
Tue, Aug 27, 2:52 PM
Unknown Object (File)
Jul 31 2024, 12:46 PM
Unknown Object (File)
Jun 29 2024, 12:22 AM
Unknown Object (File)
May 21 2024, 11:56 PM

Details

Reviewers
emaste
Summary

Add extra debugging to get the vap/vif and sta/ni states
in case we see the "Invalid TXQ id" message from iwlwifi.
Adding a backtrace will not do us much good as we will only
see the deferred TX context but not the origin of the packet.
If we really wanted we could dump the full packet contents
in hex to see what is going out (but quoting from memory
I believe it was all mgmt:auth frames?)

PR: 274382

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56029
Build 52918: arc lint + arc unit

Event Timeline

bz requested review of this revision.Feb 14 2024, 3:51 PM

How chatty is LINUXKPI_DEBUG_80211 in general? I currently do not have it enabled in my WIP tree but will turn it on for this change.

How chatty is LINUXKPI_DEBUG_80211 in general? I currently do not have it enabled in my WIP tree but will turn it on for this change.

Should not be much at all unless its (a) enabled by sysctl or (b) we have unconditional printfs currently

emaste requested changes to this revision.Feb 14 2024, 6:41 PM
emaste added inline comments.
sys/compat/linuxkpi/common/src/linux_80211.c
247

build fails with "no previous prototype"

263
This revision now requires changes to proceed.Feb 14 2024, 6:41 PM
sys/compat/linuxkpi/common/src/linux_80211.c
247

makes sense; also the function called above needs STA tracing on to print; @cc managed and got some results on the PR for at least the vap/vif. I'll update this once the other full-system compiles have finished.

bz retitled this revision from UNTESTED DEBUG: extra PR 274382 debugging to LinuxKPI: 802.11: iwlwifi: add extra debugging.Feb 14 2024, 10:25 PM
bz edited the summary of this revision. (Show Details)
bz added a subscriber: wireless.

Decouple from LINUXKPI DEBUGGING and lkpi_llsta_dump.
Seems to compile for me now too.

bz marked 2 inline comments as done.Feb 14 2024, 10:41 PM
This revision is now accepted and ready to land.Feb 15 2024, 4:35 AM

In favour of hopefully a fix in the right direction: https://reviews.freebsd.org/D43944