Page MenuHomeFreeBSD

callout: retire callout_async_drain()
ClosedPublic

Authored by glebius on Jan 22 2024, 8:43 PM.
Tags
None
Referenced Files
F95998921: D43546.diff
Mon, Sep 23, 7:23 AM
Unknown Object (File)
Sun, Sep 8, 10:31 AM
Unknown Object (File)
Sun, Sep 1, 3:22 AM
Unknown Object (File)
Sun, Sep 1, 3:22 AM
Unknown Object (File)
Sun, Sep 1, 3:22 AM
Unknown Object (File)
Sun, Sep 1, 3:22 AM
Unknown Object (File)
Sun, Sep 1, 3:10 AM
Unknown Object (File)
Aug 6 2024, 9:15 PM
Subscribers

Details

Summary

This function was used only in TCP before 446ccdd08e2a. It was born in
pain in 2016 to plug different complex panics in TCP timers. It wasn't
warmly accepted in phabricator by all of the reviewers and my recollection
of overall agreement was that "if you need this KPI, then you'd better fix
your code to not need it". However, the function served its duty well all
the way to FreeBSD 14. But now that TCP doesn't need it anymore, let's
retire it to reduce complexity of callout code and also to avoid its
further use.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55547
Build 52436: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 22 2024, 9:44 PM

You should also remove the MLINK in share/man/man9/Makefile.

There is a comment in tcp_var.h which still references callout_async_drain().

There is a comment in tcp_var.h which still references callout_async_drain().

Oops, I missed your recent commit. :)

Remove MLINK.

The comment in tcp_var.h was updates as a separate commit.

This revision now requires review to proceed.Jan 22 2024, 10:13 PM

I guess ObsoleteFiles.inc should also be updated to include callout_async_drain.9.

This revision is now accepted and ready to land.Jan 22 2024, 10:18 PM
This revision was automatically updated to reflect the committed changes.