arm64: fix the handling of DDB symbols in early boot
ClosedPublic
Actions

Authored by dfr on Jan 18 2024, 8:36 AM.

Details

Reviewers

mmel
imp
kevans
andrew
manu
emaste

Commits

rG9fac39c63c12: arm64: fix the handling of DDB symbols in early boot

Summary

The code which installs the kernel symbol table wasn't being compiled
because the file did not include opt_ddb.h

MFC after: 1 week

Test Plan

Boot a kernel using 'boot -d' and check that symbols are present

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55473
Build 52362: arc lint + arc unit

Event Timeline

dfr created this revision.Jan 18 2024, 8:36 AM

Herald added a reviewer: andrew. · View Herald TranscriptJan 18 2024, 8:36 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: emaste. · View Herald Transcript

dfr requested review of this revision.Jan 18 2024, 8:36 AM

Harbormaster completed remote builds in B55473: Diff 132913.Jan 18 2024, 8:36 AM

whoops

This revision is now accepted and ready to land.Jan 18 2024, 4:18 PM

emaste accepted this revision.Jan 18 2024, 4:26 PM

Closed by commit rG9fac39c63c12: arm64: fix the handling of DDB symbols in early boot (authored by dfr). · Explain WhyJan 18 2024, 4:41 PM

This revision was automatically updated to reflect the committed changes.

dfr added a commit: rG9fac39c63c12: arm64: fix the handling of DDB symbols in early boot.

Somewhere I have a linter for bugs like this. Lemme see if I can find it....

Revision Contents
Changeset List

Path

Size

sys/

arm64/

machdep_boot.c

5 lines

Diff 132913

View Options

sys/arm64/arm64/machdep_boot.c

arm64: fix the handling of DDB symbols in early bootClosedPublicActions