file: Use the right fd in fgetvp_lookup()

[markj]

Summary

This is a no-op for now since the sole caller passes fd=ndp->ni_dirfd,
but the old code was still wrong. For some reason I do not see a
warning about "fd" being unused.

[kib]

What is the expected semantic for the case of fd != ndp->ni_dirfd?

My first reaction to the patch was to propose removing the fd argument instead.

[markj]

In D43257#985958, @kib wrote:

What is the expected semantic for the case of fd != ndp->ni_dirfd?

Indeed, it does not make much sense.

My first reaction to the patch was to propose removing the fd argument instead.

Same for fgetvp_lookup_smr() then, I suppose?

[kib]

In D43257#985970, @markj wrote:

In D43257#985958, @kib wrote:

My first reaction to the patch was to propose removing the fd argument instead.

Same for fgetvp_lookup_smr() then, I suppose?

Definitely. Also perhaps it is time to remove the CAPABILITIES option.

[markj]

In D43257#985983, @kib wrote:

In D43257#985970, @markj wrote:

In D43257#985958, @kib wrote:

My first reaction to the patch was to propose removing the fd argument instead.

Same for fgetvp_lookup_smr() then, I suppose?

Definitely. Also perhaps it is time to remove the CAPABILITIES option.

I'm for it. There was this attempt which apparently failed: D10776. The reasons are probably mostly gone since arm64's compat32 support has evolved and mips is gone. Maybe @oshogbo or @emaste have an opinion on this?

[markj]

• Remove the "fd" parameter entirely.
• Update fgetvp_lookup_smr() similarly.