Remove pre-C11 supports from stdlib
Details
Details
- Reviewers
jrtc27 jhb imp - Group Reviewers
Contributor Reviews (src) - Commits
- rG7c7299df76e2: libc: Remove support for pre-C99 C standards
make buildworld make buildkernel
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 55518 Build 52407: arc lint + arc unit
Event Timeline
| lib/libc/stdlib/div.c | ||
|---|---|---|
| 43–44 | This code isn't compiled for c99 and higher. Shouldn't you remove it? | |
| lib/libc/stdlib/imaxdiv.c | ||
| 38–39 | Same | |
| lib/libc/stdlib/ldiv.c | ||
| 45–46 | Same | |
| lib/libc/stdlib/lldiv.c | ||
| 38–39 | Same | |
| share/mk/bsd.sys.mk | ||
| 23 ↗ | (On Diff #132026) | This line should remain |
| sys/conf/kern.mk | ||
| 288 | This line should remain | |
| usr.bin/lex/initscan.c | ||
| 34 | Where's the end removed? | |
| usr.bin/lex/initskel.c | ||
| 474 | Same | |
| share/mk/bsd.sys.mk | ||
|---|---|---|
| 14 ↗ | (On Diff #132029) | This is not just used by the base system, but by anything built using bsd.*.mk including various ports. Removing the ability to set CSTD needs an exp-run, not just testing buildworld. |
| share/mk/bsd.sys.mk | ||
|---|---|---|
| 14 ↗ | (On Diff #132029) | To be clear, I think requiring C11 for the base system (and removing bits from libc, etc. for older C) is probably reasonable, but removing the build glue that might be used in ports is probably too aggressive. |
| share/mk/bsd.sys.mk | ||
|---|---|---|
| 14 ↗ | (On Diff #132029) | Let's put a .error for the old standards and which ports break in an exprun... then we can decide what to do. |
| share/mk/bsd.sys.mk | ||
|---|---|---|
| 14 ↗ | (On Diff #132029) | The only problem here is -std=c94 and -std=c95 since they are not implemented in clang. $ clang -std=c94 main.c error: invalid value 'c94' in '-std=c94' note: use 'c89', 'c90', or 'iso9899:1990' for 'ISO C 1990' standard note: use 'iso9899:199409' for 'ISO C 1990 with amendment 1' standard note: use 'gnu89' or 'gnu90' for 'ISO C 1990 with GNU extensions' standard note: use 'c99' or 'iso9899:1999' for 'ISO C 1999' standard note: use 'gnu99' for 'ISO C 1999 with GNU extensions' standard note: use 'c11' or 'iso9899:2011' for 'ISO C 2011' standard note: use 'gnu11' for 'ISO C 2011 with GNU extensions' standard note: use 'c17', 'iso9899:2017', 'c18', or 'iso9899:2018' for 'ISO C 2017' standard note: use 'gnu17' or 'gnu18' for 'ISO C 2017 with GNU extensions' standard note: use 'c2x' for 'Working Draft for ISO C2x' standard note: use 'gnu2x' for 'Working Draft for ISO C2x with GNU extensions' standard |
Comment Actions
Add .error for c94 and c95 flags which are undefined in clang. Other flags are defined by default.
| share/mk/bsd.sys.mk | ||
|---|---|---|
| 15 ↗ | (On Diff #132736) | I think you misunderstand what the old code does here. The old code maps "c94" and "c95" to the supported string you now use in the error message. I think you should leave this part unchanged. If we want to deprecate older versions (which should be a separate commit and run via an exp-run in ports), we should add explicit .error's for older standards, e.g.: .if ${CSTD} == "c89" || ${CSTD} == "c90"
.error "Only c99 or later is supported"
...However, the old code doesn't pass -cstd=c94 to either clang or GCC today, so I don't think the argument for removing the current bits is valid. |
| sys/conf/kern.mk | ||
|---|---|---|
| 285 | It might be nice to explicitly .error here for older C standards, but that isn't required. We might want a comment here saying what our actual minimum version is (even in today's sources we probably should be saying we require gnu99 at minimum). It might be worth fixing this file as cleanup commit first to document our current de facto minimum (gnu99) and removing the support in this file for older versions. This file is only used for the kernel and associated modules so doesn't need the same legacy support as bsd.sys.mk. | |
Comment Actions
Originally this was both kernel and user space compilation, and that is why there are changes for libc, too. Modifying share/mk/bsd.sys.mk can brake port builds, but this revision has all the changes we need for both kernel and userland compilation.
| sys/conf/kern.mk | ||
|---|---|---|
| 279–283 | I would commit this part separately from the other changes | |
Comment Actions
The commit log though can say "Remove pre-C99 support" though since the blocks are all for pre-C99.