nfsclient: handle page and buffer cache consistency()
ClosedPublic
Actions

Authored by kib on Dec 30 2023, 7:03 PM.

Details

Reviewers

rmacklem
asomers

Commits

rG47ec00d9d607: nfsclient: flush dirty pages of the vnode
rG7dae1467d72a: nfsclient copy_file_range(): flush dst vnode data

Summary

nfsclient: flush dirty pages of the vnode

before ncl_flush() when done to ensure that the server sees our cached
data.

Convert LK_SHARED invp lock into LK_EXCLUSIVE if needed to call
vm_object_page_clean().

Otherwise server-side copy makes the client cache inconsistent with the
server data.

nfsclient copy_file_range(): flush dst vnode data

Otherwise server-side copy makes the client cache inconsistent with the
server data.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Dec 30 2023, 7:03 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 30 2023, 7:03 PM

kib requested review of this revision.Dec 30 2023, 7:03 PM

This is the same as the 2nd patch you posted to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276002, right? That one does not fix the test case.

In D43250#985698, @asomers wrote:

This is the same as the 2nd patch you posted to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276002, right? That one does not fix the test case.

Right, this is exactly the same patch. It is still required, despite there is something more than just copy_file_range() cache bugs.

Two more places where we need to launder pages in the cache.

kib retitled this revision from nfsclient: handle page and buffer cache consistency for copy_file_range() to nfsclient: handle page and buffer cache consistency().Dec 31 2023, 5:29 AM

kib edited the summary of this revision. (Show Details)

This looks fine to me. I did a little testing and did not
find any regression.

This revision is now accepted and ready to land.Dec 31 2023, 5:00 PM

Closed by commit rG7dae1467d72a: nfsclient copy_file_range(): flush dst vnode data (authored by kib). · Explain WhyJan 5 2024, 5:01 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG7dae1467d72a: nfsclient copy_file_range(): flush dst vnode data.

kib added a commit: rG47ec00d9d607: nfsclient: flush dirty pages of the vnode.