Page MenuHomeFreeBSD
Differential D43085

tcp: properly unroll sack transmission on tx error with LRD
ClosedPublic
Actions

Authored by rscheff on Dec 18 2023, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 10:00 PM
Unknown Object (File)
Mon, Jan 13, 10:43 PM
Unknown Object (File)
Mon, Jan 13, 9:08 PM
Unknown Object (File)
Fri, Jan 10, 6:46 PM
Unknown Object (File)
Dec 23 2024, 11:14 PM
Unknown Object (File)
Nov 24 2024, 9:33 PM
Unknown Object (File)
Nov 20 2024, 10:37 AM
Unknown Object (File)
Nov 14 2024, 7:33 PM
View All 50 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
cc
tuexen
thj
olivier
rrs
Group Reviewers
transport
Commits
rGac83f3fa44f3: tcp: properly unroll SACK transmission on TX error with LRD
rGe3b9058e5cd0: tcp: properly unroll sack transmission on tx error with LRD
Summary

While going over the code looing at PR275798, I spotted that
with LRD the rewind of the sackhole retransmission pointer
would not necessarily be calculcated correctly. In particular
with LRD, we point to snd_recover when a hole is fully retransmitted.
Need to account for that in case of a local transmission error.

PR: 275798
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54985
Build 51874: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines

Diff 131519

View Options

sys/netinet/tcp_output.c

Loading...