Page MenuHomeFreeBSD

scmi: Add new SCMI interfaces for init and message processing
ClosedPublic

Authored by cristian.marussi_arm.com on Dec 13 2023, 6:37 PM.
Tags
None
Referenced Files
F102758524: D43044.diff
Sat, Nov 16, 6:33 PM
Unknown Object (File)
Tue, Nov 5, 1:10 AM
Unknown Object (File)
Mon, Nov 4, 10:43 PM
Unknown Object (File)
Mon, Nov 4, 10:43 PM
Unknown Object (File)
Mon, Nov 4, 10:43 PM
Unknown Object (File)
Mon, Nov 4, 10:36 PM
Unknown Object (File)
Mon, Nov 4, 10:36 PM
Unknown Object (File)
Mon, Nov 4, 10:26 PM
Subscribers

Details

Summary

Introduce a couple of new SCMI interface methods to allow centralized
initialization of transport-specific features and a couple of methods
to handle message reception from the SCMI core.

Move SCMI SMT related calls out of the core common SCMI code into the
transport specific layers Mailbox/SMC.

Make SCMI Mailbox/SMC transports use the new interface methods for
initialization and message reception.

Tested on: ARM Morello Board
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The attach and detach functions that just call smci_attach and smci_detach could be removed. If a driver doesn't implement a method, but the parent does then the parent implementation will be used.

The attach and detach functions that just call smci_attach and smci_detach could be removed. If a driver doesn't implement a method, but the parent does then the parent implementation will be used.

Thanks, did not know that, I'll fix.

Removed needless empty interface methods

Removed from SMC/MAILBOX the interface methods that just simply called
the parent scmi_attach()/scmi_detach()

sys/dev/firmware/arm/scmi.c
147

I think this can stay static

sys/dev/firmware/arm/scmi.c
147

I'll do. Thanks for ponting out.

Made scmi_detach static

scmi_detach is not needed anywhere else outside so made it static.

This revision is now accepted and ready to land.Mar 8 2024, 2:46 PM