libc/*/SYS.h: remove SYCALL macro
ClosedPublic
Actions

Authored by brooks on Dec 11 2023, 9:13 PM.

Details

Reviewers

andrew
peter
cognet
jhibbits
br
imp

Commits

rG9aaf4e3be61f: libc/*/SYS.h: remove SYCALL macro

Summary

This hasn't been a univerally available interface since it was removed
from amd64 by commit efbef97de9805dec95db09953426f0b21bb2964f in 2004.
I removed the last consumers in 2016 when I replaced pipe(2) with
pipe2(2) in commit b60998c6331e2be21f1fc29fa6c82d94a1f72ef0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54896
Build 51785: arc lint + arc unit

Event Timeline

brooks created this revision.Dec 11 2023, 9:13 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptDec 11 2023, 9:13 PM

brooks requested review of this revision.Dec 11 2023, 9:13 PM

Harbormaster completed remote builds in B54896: Diff 131261.Dec 11 2023, 9:13 PM

I love the smell of deleted cruft.

This revision is now accepted and ready to land.Dec 11 2023, 9:20 PM

it would be nice if there were a universal _SYSCALL for all platforms... x86 seems to be missing it... Sometimes I want to create binaries with *JUST* system calls... though maybe libsys will be that thing?

But this is fine.

In D42996#980425, @imp wrote:

it would be nice if there were a universal _SYSCALL for all platforms... x86 seems to be missing it... Sometimes I want to create binaries with *JUST* system calls... though maybe libsys will be that thing?

Coming soon, but I figured I'd get this one out of the way since it's lower risk than touching code that's actually used.

Forgot to tick accepted, but clicking it harder after brooks' answer :)

Closed by commit rG9aaf4e3be61f: libc/*/SYS.h: remove SYCALL macro (authored by brooks). · Explain WhyDec 12 2023, 10:55 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG9aaf4e3be61f: libc/*/SYS.h: remove SYCALL macro.