Page MenuHomeFreeBSD

Revert "linuxkpi: `GFP_KERNEL` equals `M_NOWAIT` now"
ClosedPublic

Authored by dumbbell on Dec 7 2023, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 4:44 PM
Unknown Object (File)
Sat, Oct 26, 5:20 AM
Unknown Object (File)
Mon, Oct 21, 6:50 AM
Unknown Object (File)
Oct 4 2024, 8:37 PM
Unknown Object (File)
Oct 4 2024, 8:00 AM
Unknown Object (File)
Oct 4 2024, 4:52 AM
Unknown Object (File)
Oct 3 2024, 9:06 AM
Unknown Object (File)
Oct 3 2024, 7:24 AM

Details

Summary

This change seems to break some drivers such as the mlx5*(4) drivers.

As kib@ says:

According to the 'official' Linux kernel documentation, the GFP_KERNEL
flag implies sleepable context.

It was introduced while working on the new vt(4)/DRM integration. During this work, doing sleepable allocations broke vt(4) and the DRM drivers. However, I made further improvements and some locking-related fixed to the new integration without revisiting the need for it.

After more testing, the improvements to the integration mentionned above seems to make the change to GFP_KERNEL unneeded now. I can thus revert it to restore expectations of other drivers.

This reverts commit D42054.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I did it locally for Nvidia to keep stuff running.

This revision is now accepted and ready to land.Dec 7 2023, 7:40 PM