Page MenuHomeFreeBSD

busdma: emit a warning for use of filters
ClosedPublic

Authored by mhorne on Dec 4 2023, 3:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 13 2024, 5:25 PM
Unknown Object (File)
Oct 13 2024, 5:25 PM
Unknown Object (File)
Oct 13 2024, 5:24 PM
Unknown Object (File)
Oct 13 2024, 5:21 PM
Unknown Object (File)
Sep 18 2024, 2:55 PM
Unknown Object (File)
Sep 5 2024, 4:38 AM
Unknown Object (File)
Sep 2 2024, 6:07 AM
Unknown Object (File)
Sep 2 2024, 6:06 AM
Subscribers

Details

Summary

Filter functions are deprecated, and unused in the tree. If either of
the filter or filterarg arguments to bus_dma_tag_create() are non-NULL,
print a warning.

This is a direct commit to stable/14.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Dec 4 2023, 3:49 PM
emaste added inline comments.
sys/arm/arm/busdma_machdep.c
403

maybe "use of busdma filters"?

Although perhaps the man page reference is enough of a clue

This revision is now accepted and ready to land.Dec 4 2023, 6:01 PM

It's a shame we can't print out the name of the offending device. Probably want this in stable/13 as well.

It's a shame we can't print out the name of the offending device.

Indeed - I'm not particularly familiar with this interface but went looking to see if there was a reasonable way to give more information. We could perhaps print a backtrace? In practice though if a user sees this message asking for a (perhaps verbose) dmesg should be sufficient, I'd think.

This revision was automatically updated to reflect the committed changes.