480.leapfile-ntpd: only attempt to refresh leap-seconds.list when ntpd is enabled.
ClosedPublic
Actions

Authored by delphij on Dec 2 2023, 6:57 AM.

Details

Reviewers

cy
michaelo
imp

Commits

rG66bb668fe5f2: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list
rGa3b7bafd2acc: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list
rG80560eec655a: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list
rG3ef596c6e805: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list
rG52369c5d29f5: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list
rG3b3195f6767b: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list

Summary

The leap-seconds.list is used exclusively by ntpd, therefore, do not bother
to perform the fetch when ntpd is not enabled.

PR: conf/275419

Test Plan

run periodic script with ntpd enabled and disabled

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Dec 2 2023, 6:57 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 2 2023, 6:57 AM

delphij requested review of this revision.Dec 2 2023, 6:57 AM

Harbormaster completed remote builds in B54745: Diff 130930.Dec 2 2023, 6:57 AM

Update patch so it's splitted into two.

Harbormaster completed remote builds in B54746: Diff 130931.Dec 2 2023, 7:04 AM

delphij edited the summary of this revision. (Show Details)Dec 2 2023, 7:05 AM

delphij added a child revision: D42876: ntp: change ntp_leapfile_sources to use IERS version of leap-seconds.list, as IETF is no longer providing the service..Dec 2 2023, 7:11 AM

Makes sense at least to me.

This revision is now accepted and ready to land.Dec 2 2023, 12:22 PM

cy accepted this revision.Dec 2 2023, 3:55 PM

This looks good...
Though I thought there was a leapsecond file that the 'right' version of the timezone files used for systems that run in TAI... If you are sure they are unconnected, then this is perfect.

Closed by commit rG3b3195f6767b: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list (authored by delphij). · Explain WhyDec 3 2023, 7:02 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rG3b3195f6767b: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list.

delphij added a commit: rG52369c5d29f5: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list.Dec 6 2023, 6:34 AM

delphij added a commit: rG3ef596c6e805: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list.

delphij added a commit: rG80560eec655a: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list.Dec 6 2023, 7:56 AM

philip added a commit: rGa3b7bafd2acc: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list.Feb 14 2024, 6:21 AM

philip added a commit: rG66bb668fe5f2: periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list.Feb 14 2024, 6:28 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

periodic/

etc/

daily/

480.leapfile-ntpd

4 lines

Diff 130957

View Options

usr.sbin/periodic/etc/daily/480.leapfile-ntpd

periodic/daily/480.leapfile-ntpd: only attempt to refresh leap-seconds.list when ntpd is enabled.ClosedPublicActions