Page MenuHomeFreeBSD

tcp: properly initialize LRD while accepting session in syncache
ClosedPublic

Authored by rscheff on Dec 1 2023, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 10:08 AM
Unknown Object (File)
Tue, Sep 24, 9:08 AM
Unknown Object (File)
Tue, Sep 24, 8:53 AM
Unknown Object (File)
Tue, Sep 24, 8:40 AM
Unknown Object (File)
Mon, Sep 23, 4:17 PM
Unknown Object (File)
Fri, Sep 20, 5:56 PM
Unknown Object (File)
Thu, Sep 19, 12:24 PM
Unknown Object (File)
Thu, Sep 19, 2:00 AM
Subscribers

Details

Summary

After the recent LRD related changes, I noted that accept()ed
sessions would not honor the per-session TF_LRD flag.

Initialize this not only in tcp_newtcpcb, but also in syncache_socket.

Test Plan

drop a data segment and the retransmission on a SACK session,
verify that another retransmission happens well before the
retransmission timeout.

MFC: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54743
Build 51632: arc lint + arc unit

Event Timeline

sys/netinet/tcp_syncache.c
955

Alternatively, the TF_LRD flag could be inherited from the listen socket here with (TF_LRD|TF_NOPUSH|TF_NODELAY)

sys/netinet/tcp_syncache.c
955

Inheriting is what I would prefer.

  • inherit LRD setting from listening socket
This revision is now accepted and ready to land.Dec 2 2023, 11:13 AM