Paths

Table of Contentst

Differential D42596

arm64: Allow userspace to be built with PAC and BTI
ClosedPublic
Actions

Authored by andrew on Nov 14 2023, 3:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 7, 5:10 PM

	Unknown Object (File)
	Wed, Nov 6, 4:13 PM

	Unknown Object (File)
	Fri, Nov 1, 2:17 AM

	Unknown Object (File)
	Fri, Nov 1, 2:17 AM

	Unknown Object (File)
	Fri, Nov 1, 2:17 AM

	Unknown Object (File)
	Fri, Nov 1, 2:17 AM

	Unknown Object (File)
	Fri, Nov 1, 2:17 AM

	Unknown Object (File)
	Fri, Nov 1, 2:17 AM

Subscribers

Details

Reviewers

manu
emaste

Group Reviewers

Commits

rG82854693aec1: arm64: Allow userspace to be built with PAC and BTI

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Nov 14 2023, 3:16 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 14 2023, 3:16 PM

Herald added subscribers: dab, emaste, imp, bdrewery. · View Herald Transcript

andrew requested review of this revision.Nov 14 2023, 3:16 PM

andrew added a parent revision: D42595: arm64: Mark the armv8 crc32c as supporting BTI.

Harbormaster completed remote builds in B54418: Diff 130078.Nov 14 2023, 3:16 PM

Description file(s) to go in tools/build/options/ are missing

Remove debugging

Harbormaster completed remote builds in B54419: Diff 130079.Nov 14 2023, 3:24 PM

Rebase and disable until we can check all relavant toolchains support it

Harbormaster completed remote builds in B57173: Diff 137312.Apr 18 2024, 4:34 PM

emaste added inline comments.Apr 18 2024, 4:39 PM

lib/libomp/Makefile
3	Should be `:=no`? (Even though we're setting it before including other things.)

Add missing WITH/WITHOUT files

Harbormaster completed remote builds in B57174: Diff 137313.Apr 18 2024, 4:40 PM

Use := to disable branch protection

Harbormaster completed remote builds in B57839: Diff 138900.May 22 2024, 9:47 AM

:= -> = again after a comment from @emaste on IRC

Harbormaster completed remote builds in B57848: Diff 138927.May 22 2024, 2:49 PM

LGTM. Should probably expand the WITH_BRANCH_PROTECTION text though, at least mentioning on which architecture it applies (can be enabled / has an effect).

This revision is now accepted and ready to land.May 22 2024, 3:08 PM

Closed by commit rG82854693aec1: arm64: Allow userspace to be built with PAC and BTI (authored by andrew). · Explain WhyMay 22 2024, 5:03 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG82854693aec1: arm64: Allow userspace to be built with PAC and BTI.

Revision Contents
Changeset List

Path

Size

lib/

libomp/

3 lines

share/

mk/

6 lines

5 lines

6 lines

stand/

3 lines

tools/

build/

options/

WITHOUT_BRANCH_PROTECTION

1 line

WITH_BRANCH_PROTECTION

4 lines

Diff 138932

lib/libomp/Makefile

Loading...

share/mk/bsd.lib.mk

Loading...

share/mk/bsd.opts.mk

Loading...

share/mk/bsd.prog.mk

Loading...

stand/Makefile.inc

Loading...

tools/build/options/WITHOUT_BRANCH_PROTECTION

Loading...

tools/build/options/WITH_BRANCH_PROTECTION

Loading...