Page MenuHomeFreeBSD
Differential D42504

Decode pfsync packets on network interfaces
ClosedPublic
Actions

Authored by email_luiz.eng.br on Nov 8 2023, 1:25 PM.
Tags
None
Referenced Files
F102941157: D42504.diff
Tue, Nov 19, 12:47 AM
Unknown Object (File)
Sun, Nov 17, 8:53 PM
Unknown Object (File)
Sat, Nov 9, 9:35 PM
Unknown Object (File)
Wed, Nov 6, 1:35 PM
Unknown Object (File)
Tue, Nov 5, 2:56 PM
Unknown Object (File)
Mon, Oct 28, 12:14 PM
Unknown Object (File)
Mon, Oct 28, 12:14 PM
Unknown Object (File)
Oct 19 2024, 9:34 PM
View All 66 Files
Subscribers
imp

Details

Reviewers
kp
jrm
Commits
rGf88698a4ebc6: tcpdump: decode pfsync packets on network interfaces
rG85247ee6a2ba: tcpdump: decode pfsync packets on network interfaces
Summary

Looks like when print-ip-demux.c was introduced on ee67461e, the pfsync_ip_print function was missed, causing tcpdump to treat pfsync packets on network interfaces as an unknown protocol.

Sponsored by: InnoGames GmbH

Test Plan
make -C /usr/src/usr.sbin/tcpdump clean
make -C /usr/src/usr.sbin/tcpdump
make -C /usr/src/usr.sbin/tcpdump install
tcpdump -i vtnet0 'ip[9:1]==0xf0' or 'ip6[6:1]==0xf0'

The output should show packets properly decoded instead of this:

14:13:58.861597 IP 192.0.0.1 > 192.0.0.2:  ip-proto-240 216
14:13:58.861618 IP 192.0.0.1 > 192.0.0.2:  ip-proto-240 300
14:13:58.954208 IP 192.0.0.1 > 192.0.0.2:  ip-proto-240 132

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

email_luiz.eng.br created this revision.Nov 8 2023, 1:25 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 8 2023, 1:25 PM
email_luiz.eng.br requested review of this revision.Nov 8 2023, 1:25 PM
email_luiz.eng.br updated this revision to Diff 129856.Nov 8 2023, 1:32 PM

I enclosed the code with a #ifdef HAVE_NET_IF_PFLOG_H to allow for building with WITHOUT_PF=1

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2023, 5:00 PM
Closed by commit rG85247ee6a2ba: tcpdump: decode pfsync packets on network interfaces (authored by email_luiz.eng.br, committed by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG85247ee6a2ba: tcpdump: decode pfsync packets on network interfaces.
kp added a commit: rGf88698a4ebc6: tcpdump: decode pfsync packets on network interfaces.Nov 15 2023, 8:00 PM

Revision Contents
Changeset List

PathSize
contrib/
tcpdump/
4 lines

Diff 129855

View Options

contrib/tcpdump/print-ip-demux.c

Loading...