arm64: Check if PSCI before calling SMCCC
ClosedPublic
Actions

Authored by andrew on Oct 30 2023, 2:47 PM.

Details

Reviewers

stevek
manu
imp
emaste

Group Reviewers

arm64

Commits

rGeaa247c7f3df: arm64: Check if PSCI before calling SMCCC
rGb9b148609abd: arm64: Check if PSCI before calling SMCCC
rG5a8417c78f9d: arm64: Check if PSCI before calling SMCCC

Summary

As SMCCC depends on PSCI check if the latter is present before calling
the former. This fixes an issue where we may call into SMCCC when there
is no PSCI in the system causing a smccc_version assert to fail.

Reported by: stevek
Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54212
Build 51102: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 30 2023, 2:47 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 30 2023, 2:47 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 30 2023, 2:47 PM

Harbormaster completed remote builds in B54212: Diff 129518.Oct 30 2023, 2:47 PM

LGTM

imp accepted this revision.Oct 30 2023, 3:26 PM

This revision is now accepted and ready to land.Oct 30 2023, 3:26 PM

emaste accepted this revision.Oct 30 2023, 3:31 PM

Looks good, verified with the board where we had seen the issue.

Closed by commit rG5a8417c78f9d: arm64: Check if PSCI before calling SMCCC (authored by andrew). · Explain WhyNov 10 2023, 4:07 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG5a8417c78f9d: arm64: Check if PSCI before calling SMCCC.

andrew added a commit: rGb9b148609abd: arm64: Check if PSCI before calling SMCCC.Feb 19 2024, 4:46 PM

andrew added a commit: rGeaa247c7f3df: arm64: Check if PSCI before calling SMCCC.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

cpu_errata.c

8 lines

Diff 129518

View Options

sys/arm64/arm64/cpu_errata.c

arm64: Check if PSCI before calling SMCCCClosedPublicActions