ino64: Remove 'forward compat' code for this

[imp]

Summary

Forward compatibility code was added for running newer ino64 binaries on
older kernels as a transition aide. Now that ino64 has been in the tree
6 years, this code is no longer useful and should have been removed long
ago. Remove it now. Should be no user-visible changes at this point as
all the 'upgrade' scenarios it was intended for are long since past.

Sponsored by: Netflix

[emaste]

lib/libc/include/libc_private.h

345 ↗

(On Diff #129462)

wrong location?

[emaste]

do we need entries in tools/build/depend-cleanup.sh?

lib/libc/sys/stat.c

27

do we need cdefs here still? (and similar in other files)

[kib]

lib/libc/include/libc_private.h

397 ↗

(On Diff #129462)

I suggest to leave these prototypes. There is no harm keeping them, and they might become useful again.

[imp]

lib/libc/include/libc_private.h

345 ↗

(On Diff #129462)

I'm reverting this whole file, per kib@, and that will be a natural consequence.

397 ↗

(On Diff #129462)

Done. I'll leave these in.

lib/libc/sys/stat.c

27

ESCOPE.

But also, see https://reviews.freebsd.org/D42385 for removing them from libc.

[imp]

updates per the review

[emaste]

needed the following additional change to fix build:

diff --git a/libexec/rtld-elf/rtld-libc/Makefile.inc b/libexec/rtld-elf/rtld-libc/Makefile.inc
index 91eb6f5cabec..c3a74fbecbdc 100644
--- a/libexec/rtld-elf/rtld-libc/Makefile.inc
+++ b/libexec/rtld-elf/rtld-libc/Makefile.inc
@@ -56,8 +56,8 @@ CFLAGS.strtok.c+=-Wno-cast-qual
 _libc_other_objects= sigsetjmp lstat stat fstat fstatat fstatfs syscall \
     cerror geteuid getegid sigfastblock munmap mprotect \
     sysarch __sysctl issetugid __getcwd utrace getpid \
-    thr_self thr_kill pread mmap lseek _exit _fstat _fstatat _fstatfs \
-    getdirentries _getdirentries _close _fcntl _open _openat _read \
+    thr_self thr_kill pread mmap lseek _exit \
+    getdirentries _close _fcntl _open _openat _read \
     _sigprocmask _write readlink __realpathat _setjmp setjmp setjmperr

[imp]

In D42382#967424, @emaste wrote:

needed the following additional change to fix build:

diff --git a/libexec/rtld-elf/rtld-libc/Makefile.inc b/libexec/rtld-elf/rtld-libc/Makefile.inc
index 91eb6f5cabec..c3a74fbecbdc 100644
--- a/libexec/rtld-elf/rtld-libc/Makefile.inc
+++ b/libexec/rtld-elf/rtld-libc/Makefile.inc
@@ -56,8 +56,8 @@ CFLAGS.strtok.c+=-Wno-cast-qual
 _libc_other_objects= sigsetjmp lstat stat fstat fstatat fstatfs syscall \
     cerror geteuid getegid sigfastblock munmap mprotect \
     sysarch __sysctl issetugid __getcwd utrace getpid \
-    thr_self thr_kill pread mmap lseek _exit _fstat _fstatat _fstatfs \
-    getdirentries _getdirentries _close _fcntl _open _openat _read \
+    thr_self thr_kill pread mmap lseek _exit \
+    getdirentries _close _fcntl _open _openat _read \
     _sigprocmask _write readlink __realpathat _setjmp setjmp setjmperr

Somehow I missed this... but came to the same conclusion independently...