Page MenuHomeFreeBSD
Differential D42256

pdinit(): Fix comment
ClosedPublic
Actions

Authored by olce on Oct 17 2023, 2:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 10, 12:02 AM
Unknown Object (File)
Sun, Mar 9, 11:26 PM
Unknown Object (File)
Sun, Mar 9, 11:23 PM
Unknown Object (File)
Sun, Mar 9, 11:05 PM
Unknown Object (File)
Thu, Feb 20, 4:28 AM
Unknown Object (File)
Nov 28 2024, 3:47 PM
Unknown Object (File)
Nov 28 2024, 3:47 PM
Unknown Object (File)
Nov 28 2024, 3:47 PM
View All 44 Files
Subscribers
emaste
imp

Details

Reviewers
mjg
kib
markj
Commits
rGa10630ef818f: pdinit(): Fix comment
rG56bb3ce09137: pdinit(): Fix comment
Summary

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54067
Build 50957: arc lint + arc unit

Event Timeline

olce created this revision.Oct 17 2023, 2:38 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 17 2023, 2:38 PM
olce requested review of this revision.Oct 17 2023, 2:38 PM
Harbormaster completed remote builds in B54038: Diff 128919.Oct 17 2023, 2:38 PM
olce added a subscriber: emaste.Oct 17 2023, 2:40 PM
markj accepted this revision.Oct 17 2023, 2:53 PM
This revision is now accepted and ready to land.Oct 17 2023, 2:53 PM
kib accepted this revision.Oct 17 2023, 4:33 PM
kib added inline comments.
sys/kern/kern_descrip.c
2241
olce added inline comments.Oct 17 2023, 8:37 PM
sys/kern/kern_descrip.c
2241

When removing "shared", I considered replacing it with "exclusively" but didn't because the struct pwddesc lock is in fact just a mutex, so there is no provision for "shared" locking it (and it seems there never was; perhaps this was intended as future work). But ok, I'll put it, inside parentheses.

olce updated this revision to Diff 129057.Oct 19 2023, 7:54 AM
olce edited the summary of this revision. (Show Details)

Add "exclusively".

This revision now requires review to proceed.Oct 19 2023, 7:54 AM
Harbormaster completed remote builds in B54067: Diff 129057.Oct 19 2023, 7:54 AM
olce marked an inline comment as done.Oct 19 2023, 8:00 AM
kib accepted this revision.Oct 19 2023, 11:27 AM
This revision is now accepted and ready to land.Oct 19 2023, 11:27 AM
Closed by commit rG56bb3ce09137: pdinit(): Fix comment (authored by olce, committed by markj). · Explain WhyNov 2 2023, 1:41 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG56bb3ce09137: pdinit(): Fix comment.
olce added a commit: rGa10630ef818f: pdinit(): Fix comment.Dec 21 2023, 1:47 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 129057

View Options

sys/kern/kern_descrip.c

Loading...