prf: add setting of msgbuftrigger in paths where it is missing
ClosedPublic
Actions

Authored by chs on Oct 12 2023, 6:45 PM.

Details

Reviewers

kib
imp

Commits

rGc545a7b2c7db: prf: add setting of msgbuftrigger in paths where it is missing

Summary

Logging things to msgbuf is supposed to set msgbuftrigger so that
syslogd will notice that there is more to read from /dev/klog,
but several paths do not do that. Add the missing trigger.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chs created this revision.Oct 12 2023, 6:45 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 12 2023, 6:45 PM

chs requested review of this revision.Oct 12 2023, 6:45 PM

Harbormaster completed remote builds in B53946: Diff 128679.Oct 12 2023, 6:45 PM

imp accepted this revision.Oct 12 2023, 6:55 PM

This revision is now accepted and ready to land.Oct 12 2023, 6:55 PM

This mechanism seems to be quite fragile. In particular, I do not see any guarantee that other CPUs would see msgbuf write when msgbuftrigger is set to 1.

I agree, this msgbuftrigger thing is rather loosey-goosey. I'm just trying to have all the msgbuf paths achieve a consistent level of loosey-gooseyness.

Closed by commit rGc545a7b2c7db: prf: add setting of msgbuftrigger in paths where it is missing (authored by chs). · Explain WhyOct 13 2023, 10:03 PM

This revision was automatically updated to reflect the committed changes.

chs added a commit: rGc545a7b2c7db: prf: add setting of msgbuftrigger in paths where it is missing.