Page MenuHomeFreeBSD
Differential D42086

certctl: Clean up.
ClosedPublic
Actions

Authored by des on Oct 5 2023, 11:22 AM.
Tags
None
Referenced Files
F112553087: D42086.diff
Wed, Mar 19, 6:33 PM
Unknown Object (File)
Mon, Mar 17, 1:46 AM
Unknown Object (File)
Tue, Feb 25, 12:01 PM
Unknown Object (File)
Sat, Feb 22, 11:34 AM
Unknown Object (File)
Thu, Feb 20, 4:40 PM
Unknown Object (File)
Jan 30 2025, 10:35 AM
Unknown Object (File)
Jan 24 2025, 5:05 PM
Unknown Object (File)
Jan 17 2025, 11:53 AM
View All 53 Files
Subscribers
imp

Details

Reviewers
allanjude
Group Reviewers
security
Commits
rGeed04cc1699b: certctl: Clean up.
rG1525625c7c94: certctl: Clean up.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53848
Build 50739: arc lint + arc unit

Event Timeline

des created this revision.Oct 5 2023, 11:22 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 5 2023, 11:22 AM
des requested review of this revision.Oct 5 2023, 11:22 AM
Harbormaster completed remote builds in B53848: Diff 128283.Oct 5 2023, 11:22 AM
des added a child revision: D42087: certctl: Split certificate bundles before processing..Oct 5 2023, 11:22 AM
allanjude accepted this revision.Oct 5 2023, 12:47 PM

A few small comments, but looks good to me

reviewed-by: allanjude

usr.sbin/certctl/certctl.sh
34

this part of the change means you can no longer control the VERBOSE setting by setting an environment variable.

When certctl is run as part of scripts, or installworld etc, it helps to be able to see what it is doing.

112

we probably need to quote "$(realpath "$1")" incase the path might have a space in it

This revision is now accepted and ready to land.Oct 5 2023, 12:47 PM
des updated this revision to Diff 128288.Oct 5 2023, 1:57 PM

review feedback

This revision now requires review to proceed.Oct 5 2023, 1:57 PM
Harbormaster completed remote builds in B53851: Diff 128288.Oct 5 2023, 1:57 PM
des marked 2 inline comments as done.Oct 5 2023, 1:58 PM
des added inline comments.
usr.sbin/certctl/certctl.sh
34

You can now define CERTCTL_VERBOSE to a non-empty value to get the same effect.

allanjude accepted this revision.Oct 5 2023, 2:00 PM

CERTCTL_VERBOSE is even better. Thank you.

reviewed-by: allanjude

This revision is now accepted and ready to land.Oct 5 2023, 2:00 PM
Closed by commit rG1525625c7c94: certctl: Clean up. (authored by des). · Explain WhyOct 5 2023, 3:13 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG1525625c7c94: certctl: Clean up..
emaste added a commit: rGeed04cc1699b: certctl: Clean up..Thu, Feb 20, 1:08 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
certctl/
170 lines

Diff 128283

View Options

usr.sbin/certctl/certctl.sh

Loading...