Paths

Table of Contentst

Differential D41980

lib/libc/amd64/string: implement strpbrk() through strcspn()
ClosedPublic
Actions

Authored by fuz on Sep 25 2023, 9:49 PM.

Tags

None

Referenced Files

	F102695543: D41980.diff
	Fri, Nov 15, 11:36 PM

	Unknown Object (File)
	Oct 16 2024, 6:55 PM

	Unknown Object (File)
	Sep 30 2024, 5:02 PM

	Unknown Object (File)
	Sep 18 2024, 5:58 AM

	Unknown Object (File)
	Sep 17 2024, 12:00 PM

	Unknown Object (File)
	Sep 9 2024, 1:26 AM

	Unknown Object (File)
	Sep 8 2024, 10:20 PM

	Unknown Object (File)
	Sep 8 2024, 4:29 AM

View All 31 Files

Subscribers

Details

Reviewers

mjg
kib

Commits

rGf42eca44bdfb: share/man/man7/simd.7: document amd64 SIMD use for strpbrk()
rG309b30ce8419: lib/libc/amd64/string: implement strpbrk() through strcspn()
rG8b60e1fdbefa: share/man/man7/simd.7: document amd64 SIMD use for strpbrk()
rGf4fc317c364f: lib/libc/amd64/string: implement strpbrk() through strcspn()

Summary

This lets us use our optimised strcspn() routine for strpbrk() calls.

In principle, this change could be applied to all architectures
through modification of lib/libc/string/strpbrk.c as strcspn
has a better generic implementation than strpbrk. I have avoided
this as to reduce the impact of these changes. If desired I can
update this DR to do so.

Sponsored by: The FreeBSD Foundation

Test Plan

passes test suite

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fuz created this revision.Sep 25 2023, 9:49 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 25 2023, 9:49 PM

fuz requested review of this revision.Sep 25 2023, 9:49 PM

Harbormaster completed remote builds in B53721: Diff 127807.Sep 25 2023, 9:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 25 2023, 2:26 PM

Closed by commit rGf4fc317c364f: lib/libc/amd64/string: implement strpbrk() through strcspn() (authored by fuz). · Explain Why

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rGf4fc317c364f: lib/libc/amd64/string: implement strpbrk() through strcspn().

fuz added a commit: rG8b60e1fdbefa: share/man/man7/simd.7: document amd64 SIMD use for strpbrk().

fuz added a commit: rG309b30ce8419: lib/libc/amd64/string: implement strpbrk() through strcspn().Jan 24 2024, 7:45 PM

fuz added a commit: rGf42eca44bdfb: share/man/man7/simd.7: document amd64 SIMD use for strpbrk().

Revision Contents
Changeset List

Path

Size

lib/

libc/

amd64/

string/

1 line

18 lines

43 lines

Diff 131807

lib/libc/amd64/string/Makefile.inc

Loading...

lib/libc/amd64/string/strcspn.S

Loading...

lib/libc/amd64/string/strpbrk.c

Loading...