Page MenuHomeFreeBSD

syscall.master: Fix SAL annotation for getdirentires basep argument
ClosedPublic

Authored by guhaoyu2005_gmail.com on Sep 24 2023, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 3:05 PM
Unknown Object (File)
Feb 19 2025, 5:49 AM
Unknown Object (File)
Feb 19 2025, 5:23 AM
Unknown Object (File)
Feb 15 2025, 4:23 PM
Unknown Object (File)
Jan 23 2025, 2:04 PM
Unknown Object (File)
Jan 21 2025, 9:37 AM
Unknown Object (File)
Jan 10 2025, 9:16 AM
Unknown Object (File)
Nov 30 2024, 6:25 AM
Subscribers
None

Details

Summary

As suggested in getdirentires function definition, the last argument "off_t *basep" is an optional output argument. It returns the value only when the passed-in value(pointer) is non-NULL.

This case is very similiar to sendfile, where the second last argument will get a value only when it is non-NULL. The SAL annotation for this argument in syscall.master is defined as _Out_opt_.

This is a part of the research work at RCSLab, University of Waterloo.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53705
Build 50596: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 24 2023, 10:00 PM

Can you confirm that the author (for Git) should be Haoyu Gu <guhaoyu2005@gmail.com>

Can you confirm that the author (for Git) should be Haoyu Gu <guhaoyu2005@gmail.com>

Yes that is correct.