Page MenuHomeFreeBSD

syscall.master: Fix SAL annotation for getdirentires basep argument
ClosedPublic

Authored by guhaoyu2005_gmail.com on Sep 24 2023, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 1:24 PM
Unknown Object (File)
Fri, Oct 18, 1:24 PM
Unknown Object (File)
Fri, Oct 18, 1:23 PM
Unknown Object (File)
Fri, Oct 18, 1:03 PM
Unknown Object (File)
Sep 30 2024, 1:37 PM
Unknown Object (File)
Sep 24 2024, 4:05 AM
Unknown Object (File)
Sep 24 2024, 4:05 AM
Unknown Object (File)
Sep 23 2024, 12:57 PM
Subscribers
None

Details

Summary

As suggested in getdirentires function definition, the last argument "off_t *basep" is an optional output argument. It returns the value only when the passed-in value(pointer) is non-NULL.

This case is very similiar to sendfile, where the second last argument will get a value only when it is non-NULL. The SAL annotation for this argument in syscall.master is defined as _Out_opt_.

This is a part of the research work at RCSLab, University of Waterloo.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 24 2023, 10:00 PM

Can you confirm that the author (for Git) should be Haoyu Gu <guhaoyu2005@gmail.com>

Can you confirm that the author (for Git) should be Haoyu Gu <guhaoyu2005@gmail.com>

Yes that is correct.