cpufreq_dt: Find the closest frequency
ClosedPublic
Actions

Authored by manu on Sep 6 2023, 4:46 PM.

Details

Reviewers

Group Reviewers

ARM
arm64

Commits

rG62ce4a798f2c: cpufreq_dt: Find the closest frequency
rG17c17872ca98: cpufreq_dt: Find the closest frequency

Summary

When building the frequencies table we convert the value in the DTS to
megahertz and loose precision. While it's not a problem for most of the
DTS it is when the expected frequency value is strict down to the hertz.
So it's either we don't truncate the value and have some ugly and long
values in the sysctls or we just find the closest frequency.
Do the latter.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53486
Build 50377: arc lint + arc unit

Event Timeline

manu created this revision.Sep 6 2023, 4:46 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2023, 4:46 PM

manu requested review of this revision.Sep 6 2023, 4:46 PM

Harbormaster completed remote builds in B53469: Diff 126968.Sep 6 2023, 4:46 PM

manu added reviewers: ARM, arm64.Sep 6 2023, 4:46 PM

andrew added a subscriber: andrew.Sep 6 2023, 4:55 PM

andrew added inline comments.

sys/dev/cpufreq/cpufreq_dt.c
120	Why `abs(freq)`?

Remove duplicate abs()

manu marked an inline comment as done.Sep 6 2023, 5:01 PM

Harbormaster completed remote builds in B53471: Diff 126970.Sep 6 2023, 5:01 PM

mmel added a subscriber: mmel.Sep 7 2023, 5:56 AM

mmel added inline comments.

sys/dev/cpufreq/cpufreq_dt.c
120	The abs() function uses an integer as an argument. I'm afraid we don't have an abs() function for uint64_t. Besides, the result of subtracting two unsigned numbers is also an unsigned number. Imho, We can convert these frequencies to int64_t without losing anything, and then use our own version of the 'abs_i64()' function.