Page MenuHomeFreeBSD

pf: remove DIOCGETRULE and DIOCGETSTATUS
ClosedPublic

Authored by kp on Aug 30 2023, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 26, 11:49 AM
Unknown Object (File)
Tue, Sep 24, 4:56 AM
Unknown Object (File)
Tue, Sep 24, 4:50 AM
Unknown Object (File)
Wed, Sep 18, 4:35 AM
Unknown Object (File)
Wed, Sep 18, 3:21 AM
Unknown Object (File)
Wed, Sep 11, 9:19 AM
Unknown Object (File)
Sun, Sep 8, 3:57 PM
Unknown Object (File)
Sun, Sep 8, 9:11 AM

Details

Summary

These calls have nvlist variants that completely supersede them.
Remove the old code.

MFC after: never
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 30 2023, 12:53 PM
This revision was automatically updated to reflect the committed changes.

This leads the port net/py-libdnet to be broken:

--- fw-pf.lo ---
fw-pf.c:212:22: error: use of undeclared identifier 'DIOCGETRULE'
                        if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
                                          ^
fw-pf.c:252:22: error: use of undeclared identifier 'DIOCGETRULE'
                        if (ioctl(fw->fd, DIOCGETRULE, &pcr) == 0 &&
                                          ^
--- intf.lo ---
                for (cnt = 0; !matched && cnt < (int) entry->intf_alias_num; cnt++) {
                ^
intf.c:571:2: note: previous statement is here
        if (entry->intf_addr.addr_type == ADDR_TYPE_IP &&
        ^
--- fw-pf.lo ---
fw-pf.c:296:28: error: use of undeclared identifier 'DIOCGETRULE'
                if ((ret = ioctl(fw->fd, DIOCGETRULE, &pr)) < 0)
                                         ^
3 errors generated.

That leads to:

[00:00:41] [29] [00:00:26] Finished net/py-libdnet@py39 | py39-libdnet-1.13_4: Failed: build
[00:00:42] [29] [00:00:27] Skipping net/scapy@py39 | py39-scapy-2.5.0_1: Dependent port net/py-libdnet@py39 | py39-libdnet-1.13_4 failed

net/scapy is used by parts of the kyua testsuite (when installed, anyway).