syslogd: Move selector parsing into its own function
ClosedPublic
Actions

Authored by jfree on Aug 8 2023, 3:38 PM.

Details

Reviewers

markj
emaste

Commits

rGf4b4a10abb26: syslogd: Move selector parsing into its own function

Summary

Clean up the cfline() function by moving selector parsing into its
own function

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jfree created this revision.Aug 8 2023, 3:38 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2023, 3:38 PM

jfree requested review of this revision.Aug 8 2023, 3:38 PM

jfree added a parent revision: D41373: syslogd: Move prop_filter allocation into function.

jfree added a child revision: D41375: syslogd: Move action parsing into its own function.

Update after rebase

Looks good, just a couple of minor notes.

usr.sbin/syslogd/syslogd.c
2898	Wrong indentation here.
2908	I'm not sure why these lines changed, but I'm pretty sure this could be one line?

This revision is now accepted and ready to land.Aug 11 2023, 2:59 PM

Address Mark's suggestions

This revision now requires review to proceed.Aug 11 2023, 6:21 PM

markj accepted this revision.Aug 14 2023, 2:23 PM

This revision is now accepted and ready to land.Aug 14 2023, 2:23 PM

Closed by commit rGf4b4a10abb26: syslogd: Move selector parsing into its own function (authored by jfree, committed by markj). · Explain WhySep 28 2023, 3:58 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGf4b4a10abb26: syslogd: Move selector parsing into its own function.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

syslogd.c

213 lines

Diff 125844

View Options

usr.sbin/syslogd/syslogd.c

syslogd: Move selector parsing into its own functionClosedPublicActions