Page MenuHomeFreeBSD

syslogd: Clean up allowedpeer structure
ClosedPublic

Authored by jfree on Aug 8 2023, 3:25 PM.
Tags
None
Referenced Files
F102052901: D41365.diff
Thu, Nov 7, 12:52 AM
Unknown Object (File)
Sun, Oct 27, 1:00 PM
Unknown Object (File)
Mon, Oct 21, 5:24 AM
Unknown Object (File)
Mon, Oct 21, 5:24 AM
Unknown Object (File)
Mon, Oct 21, 5:24 AM
Unknown Object (File)
Mon, Oct 21, 4:00 AM
Unknown Object (File)
Mon, Oct 21, 3:59 AM
Unknown Object (File)
Mon, Oct 21, 3:59 AM
Subscribers

Details

Summary
  • Use boolean values in validate() and struct allowedpeer.
  • Remove useless peer count loop.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jfree requested review of this revision.Aug 8 2023, 3:25 PM
markj added inline comments.
usr.sbin/syslogd/syslogd.c
204

By the way, we now use anonymous unions in quite a few places, so you could instead write

union {
    struct {
        struct sockaddr_storage a_addr;
        ...
};

and get rid of those horrible defines. But that should be done in a separate diff if at all.

This revision is now accepted and ready to land.Aug 9 2023, 7:24 PM
jfree edited the summary of this revision. (Show Details)

Update after rebase

This revision now requires review to proceed.Aug 10 2023, 11:08 PM
This revision is now accepted and ready to land.Aug 11 2023, 2:50 PM
This revision was automatically updated to reflect the committed changes.