ath(4): Remove MIPS AHB frontend and join PCI one w/ main support again
ClosedPublic
Actions

Authored by marius on Aug 8 2023, 9:03 AM.

Details

Reviewers

adrian
andrew

Group Reviewers

wireless

Commits

rG37c8ee8847fa: ath(4): Remove MIPS AHB frontend and join PCI one w/ main support again

Summary

Following the removal of general MIPS support, there's no longer a need
to have the AHB bus-frontend in place, which according to Linux sources
also isn't used with any non-MIPS SoCs. For simplicity, PCI bus support
is only made conditional on the main one again, i. e. device ath_pci is
removed, and built into the main module, i. e. if_ath_pci.ko obsoleted,
respectively.
Effectively, this reverts the following commits and associated changes:
dba9c8597747c6c9bf3d2ec68f7eb90552878dc7
e849bb3ecbb1963344a22ae77fc96f89fbebf40c

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marius created this revision.Aug 8 2023, 9:03 AM

Herald added a reviewer: andrew. · View Herald TranscriptAug 8 2023, 9:03 AM

Herald added subscribers: jhibbits, imp. · View Herald Transcript

marius requested review of this revision.Aug 8 2023, 9:03 AM

Hi! I know this is a long shot, but if someone wants to do AR9271/AR7010 support (which is USB) it'll need this bus abstraction still.

This revision now requires changes to proceed.Aug 8 2023, 11:08 AM

emaste added a subscriber: emaste.Aug 8 2023, 1:21 PM

Well, the bus abstraction as such deliberately is left in place, build-wise the PCI bus front-end just is coupled with the core support again (but as for the kernel, also only if has PCI support in the first place as usual). Generally, we consider PCI default enough that there are no seperate modules and devices for PCI bus front-ends even if support for additional busses exists. Currently, ath(4) and ath_pci(4) respectively are one of the very few odd ones out in this regard (I think virtio_pci(4) is the only other offender). Also, with all support for the very resource constraint platforms already gone, even if code for said USB chips would be added today, I believe the few bytes for the bus glue won't matter. The ARMv7 if_ath_pci.o currently is 25 KB and ARMv6 support also already on its way out ...

fiiine :-P

This revision is now accepted and ready to land.Aug 8 2023, 5:05 PM

Thanks!

jlduran added a subscriber: jlduran.Aug 9 2023, 12:39 AM

jlduran added inline comments.