nvme: Remove duplicate completion printing routine

[imp]

Summary

Both nvme_dump_completion and nvme_qpair_print_completion print
completions. The latter is better. Recode the two instances of
nvme_dump_completion to use nvme_qpair_print_completion and delete the
former. No sense having two nearly identical routines

Sponsored by: Netflix

[mav]

nvme_dump_completion() also printed the phase value, that I think may be useful to read the dump, which prints all completion entries, completed or not.

[imp]

In D41308#940723, @mav wrote:

nvme_dump_completion() also printed the phase value, that I think may be useful to read the dump, which prints all completion entries, completed or not.

That's a good idea. I'll add it back. I hadn't thought it was important when I first did it, but you make a good point.

[imp]

update, per review

[mav]

nvme_printf() in nvme_qpair_print_completion() is a wrapper around device_printf(). So dump will now include device name and not at the beginning of the line. It will be weird. Plus P makes sense only in case of dump and IMO would be more readable if it would be the first there.

[imp]

In D41308#940802, @mav wrote:

nvme_printf() in nvme_qpair_print_completion() is a wrapper around device_printf(). So dump will now include device name and not at the beginning of the line. It will be weird. Plus P makes sense only in case of dump and IMO would be more readable if it would be the first there.

I'm planning in the next round to make this and the other reporting routines sbug versions. Can we defer this point until then? Or should I hold back on this one until I have that series?