hid: Add child device parameter to HID methods
ClosedPublic
Actions

Authored by wulf on Jul 31 2023, 2:55 PM.

Details

Reviewers

imp
emaste

Commits

rG4b1712817e56: hid: Add child device parameter to HID methods

Summary

Some devices like Apple HID-over-SPI may contain more than one report
descriptors necessitating creation of multiple hidbus children.
Add indentificator of child devices to distinct them.
No functional changes intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52902
Build 49793: arc lint + arc unit

Event Timeline

wulf requested review of this revision.Jul 31 2023, 2:55 PM

wulf created this revision.

Harbormaster completed remote builds in B52902: Diff 125371.Jul 31 2023, 2:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 3 2023, 4:12 PM

Closed by commit rG4b1712817e56: hid: Add child device parameter to HID methods (authored by wulf). · Explain Why

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG4b1712817e56: hid: Add child device parameter to HID methods.

It was committed on Thu Aug 3 19:10:50 2023 +0300 as 4b1712817e56840acc5e9fd59028ef79007ff579. There is no info about MFC, but this change seems to be silencing multiple messages seen in dmesg[1]. While these messages are irrelevant to HID functionality, after MFC we will get rid of them

[22] hid_get_item: HID_ITEM_MAXUSAGE should be increased up to 16 to parse the HID report descriptor
[22] hid_get_item: HID_ITEM_MAXUSAGE should be increased up to 16 to parse the HID report descriptor
[22] hid_get_item: HID_ITEM_MAXUSAGE should be increased up to 16 to parse the HID report descriptor
[22] hid_get_item: HID_ITEM_MAXUSAGE should be increased up to 16 to parse the HID report descriptor
...

Cherry-picking leads to CONFLICT (content): Merge conflict in sys/dev/hid/hidbus.c. So more MFCs are required, and it will probably break ABI. Please ignore my previous comment then.