Page MenuHomeFreeBSD

iflib(9): Remove support for cloning pseudo interfaces
ClosedPublic

Authored by marius on Jul 26 2023, 11:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 11:23 AM
Unknown Object (File)
Thu, Oct 24, 2:54 AM
Unknown Object (File)
Oct 12 2024, 12:37 PM
Unknown Object (File)
Jul 6 2024, 9:55 PM
Unknown Object (File)
Jul 4 2024, 8:08 AM
Unknown Object (File)
Jul 3 2024, 11:28 AM
Unknown Object (File)
Jun 30 2024, 9:49 AM
Unknown Object (File)
Jun 30 2024, 8:55 AM

Details

Reviewers
melifaro
shurd
kbowling
erj
Group Reviewers
iflib
Summary

The iflib(9) code for cloning pseudo interfaces was used by the first
incarnation of wg(4) and is dead ever since f187d6dfbf63 has removed
the latter again. Moreover, this code matched iflib(4) like a square
peg fits in a round hole, was incomplete and despite some hacks still
tailored to VPC and wg(4) but not generic. In effect, this reverts the
following:
09f6ff4f1a47c3009dc16fdc609a44f2341bc7ac (w/ its "ancillary changes")
9aeca21324f481f57f2ecb7009f461f4f51b62b3
1f93e931d9f0c688f43f98ef777e04636a325526
0f9544d03e89d180f94a7a84b110ec7d2b6c625a
0dd691b41276ce13d25ffb1443af27f85038aa3f

Test Plan

o Compile tested in a universe build
o Run-time tested with EM- and IGB-class hardware

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Jul 26 2023, 2:39 PM
erj added a subscriber: erj.

I like the idea, and I don't see anything that looks wrong after looking through it quickly. We've added support to ice(4) internally to allow for an extra interface for traffic mirroring that is attached to the main interface, but we're using the standard iflib device interfaces to create it and manipulate it instead of the pseudo interfaces, so this won't affect that.