Page MenuHomeFreeBSD

gve: Fix Tx tcpdump panic
ClosedPublic

Authored by shailend_google.com on Jul 26 2023, 12:37 AM.
Tags
None
Referenced Files
F98151583: D41189.diff
Wed, Oct 2, 12:29 PM
Unknown Object (File)
Mon, Sep 16, 8:15 PM
Unknown Object (File)
Mon, Sep 16, 4:46 PM
Unknown Object (File)
Sun, Sep 15, 9:07 PM
Unknown Object (File)
Aug 31 2024, 12:29 PM
Unknown Object (File)
Aug 31 2024, 12:29 PM
Unknown Object (File)
Aug 31 2024, 12:28 PM
Unknown Object (File)
Aug 31 2024, 12:15 PM
Subscribers
None

Details

Summary

Ringing the doorbell before making the BPF call can result in the
mbuf being freed before the BPF call.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shailend_google.com created this revision.
sys/dev/gve/gve_tx.c
709

BTW, this usage of drbr looks like it could be a bit simpler:

while ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) != 0 && (m = drbr_peek()) != NULL) {
    if (gve_xmit(tx, mbuf) != 0) {
        ...
    }
    drbr_advance(ifp, tx->br);
    ...
}

Right now we're needlessly checking for an empty ring in drbr_peek() after having already done so with drbr_empty().

This revision is now accepted and ready to land.Jul 26 2023, 2:33 PM
This revision was automatically updated to reflect the committed changes.