Page MenuHomeFreeBSD

libc: Migrate from COMPAT_32BIT to generic COMPAT_LIBCOMPAT
AbandonedPublic

Authored by jrtc27 on Jul 8 2023, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 24, 3:20 PM
Unknown Object (File)
Tue, Sep 24, 1:11 AM
Unknown Object (File)
Sun, Sep 22, 4:26 PM
Unknown Object (File)
Thu, Sep 19, 4:29 PM
Unknown Object (File)
Thu, Sep 19, 12:17 PM
Unknown Object (File)
Aug 30 2024, 6:57 AM
Unknown Object (File)
Aug 30 2024, 6:57 AM
Unknown Object (File)
Aug 30 2024, 6:44 AM
Subscribers

Details

Reviewers
kib
brooks
jhb
imp
Summary

In this instance we don't get any benefit from its genericity, but the
two are equivalent here and this will allow the old COMPAT_32BIT to be
removed.

Note that the fact we even look at COMPAT_32BIT here in the first place
is questionable given you don't really want amd64 lib32 libc and true
i386 libc to differ in exported symbols, so add an XXX to that effect.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52502
Build 49393: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 8 2023, 12:16 AM
lib/libc/i386/sys/Makefile.inc
5

I suggest removing the .if at all, unconditionally adding the objects (assuming it builds).

lib/libc/i386/sys/Makefile.inc
5

Turns out they do in fact build, I wonder what decade that became true in. Will drop this patch in favour of that.

lib/libc/i386/sys/Makefile.inc
5

I suspect not that much ancient history. It probably come with the unification of x86 headers.