Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make
ClosedPublic
Actions

Authored by jrtc27 on Jul 7 2023, 11:58 PM.

Details

Reviewers

emaste
imp
brooks
jhb

Commits

rG537f945fc89f: Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make

Summary

Currently none of the words in these require quoting, but a future
commit will add words that do, thus we should make sure to quote each
word so the shell doesn't mangle them before calling the sub-make.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52495
Build 49386: arc lint + arc unit

Event Timeline

jrtc27 requested review of this revision.Jul 7 2023, 11:58 PM

jrtc27 created this revision.

Harbormaster completed remote builds in B52495: Diff 124329.Jul 7 2023, 11:58 PM

jrtc27 added a child revision: D40922: bsd.compat.mk: Provide new CPP and sub-make variables.Jul 8 2023, 12:05 AM

brooks accepted this revision.Jul 8 2023, 12:35 AM

This revision is now accepted and ready to land.Jul 8 2023, 12:35 AM

LGTM.

This make magic was unfamiliar to me. It may be worth including in the commit message a brief reference to the :@varname@string@ functionality, if you're so inclined.

New make magic to me also.

Closed by commit rG537f945fc89f: Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make (authored by jrtc27). · Explain WhyJul 9 2023, 5:53 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG537f945fc89f: Makefile.libcompat: Quote CFLAGS and CXXFLAGS for sub-make.