Page MenuHomeFreeBSD
Differential D40917

Don't bother to check COMPAT_32BIT when __LP64__ is defined
ClosedPublic
Actions

Authored by jrtc27 on Jul 7 2023, 11:57 PM.
Tags
None
Referenced Files
F106963244: D40917.diff
Wed, Jan 8, 4:08 AM
Unknown Object (File)
Sun, Dec 29, 9:05 AM
Unknown Object (File)
Thu, Dec 19, 3:46 PM
Unknown Object (File)
Dec 4 2024, 7:44 AM
Unknown Object (File)
Nov 6 2024, 1:08 PM
Unknown Object (File)
Nov 6 2024, 1:08 PM
Unknown Object (File)
Nov 6 2024, 1:07 PM
Unknown Object (File)
Nov 5 2024, 12:11 AM
View All 55 Files
Subscribers
delphij
imp

Details

Reviewers
mm
brooks
jhb
imp
Commits
rGc63c4e694cfb: Don't bother to check COMPAT_32BIT when __LP64__ is defined
Summary

Under COMPAT_32BIT we are compiling 32-bit code and so LP64 is not
defined, ILP32 is, and thus the check is completely redundant.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52491
Build 49382: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jul 7 2023, 11:57 PM
Herald added subscribers: delphij, imp. · View Herald TranscriptJul 7 2023, 11:57 PM
jrtc27 requested review of this revision.Jul 7 2023, 11:57 PM
Harbormaster completed remote builds in B52491: Diff 124325.Jul 7 2023, 11:57 PM
jrtc27 added a parent revision: D40932: bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused.Jul 8 2023, 12:07 AM
jrtc27 removed a parent revision: D40932: bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused.
jrtc27 added a child revision: D40932: bsd.compat.mk: Remove obsolete COMPAT_32BIT now it's unused.
imp accepted this revision.Jul 8 2023, 12:13 AM
This revision is now accepted and ready to land.Jul 8 2023, 12:13 AM
brooks accepted this revision.Jul 8 2023, 12:33 AM

Probably should upstream this

jrtc27 added a comment.Jul 8 2023, 12:47 AM
In D40917#931597, @brooks wrote:

Probably should upstream this

Yeah, I was planning to

jhb accepted this revision.Jul 8 2023, 7:33 PM
Closed by commit rGc63c4e694cfb: Don't bother to check COMPAT_32BIT when __LP64__ is defined (authored by jrtc27). · Explain WhyJul 9 2023, 5:53 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rGc63c4e694cfb: Don't bother to check COMPAT_32BIT when __LP64__ is defined.
des added a reverting change: D41483: openzfs: Revert to last known good state..Aug 16 2023, 6:31 PM

Revision Contents
Changeset List

PathSize
sys/
cddl/
compat/
opensolaris/
sys/
4 lines
contrib/
openzfs/
include/
os/
freebsd/
spl/
sys/
4 lines

Diff 124325

View Options

sys/cddl/compat/opensolaris/sys/atomic.h

Loading...
View Options

sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h

Loading...