csu: Implement _start using as to satisfy unwinders on x86_64

[dchagin]

Summary

The right unwinding stop indicator should be CFI-undefined PC.
https://dwarfstd.org/doc/Dwarf3.pdf - page 118:
If a Return Address register is defined in the virtual unwind table,
and its rule is undefined (for example, by DW_CFA_undefined), then
there is no return address and no call address, and the virtual
unwind of stack activations is complete.

This requires the crt code be built with unwind tables, for that remove
-fno-asynchronous-unwind-tables to enable unwind tables generation.

PR: 241562, 246322, 246537

Test Plan

Not tested with GCRT

[kib]

Please add the comments, mostly by copying/pasting the C statements for calculating each __libc_start1 arg. Also please add a comment with _start() prototype.

GCRT is the gcrt1.o compilation, it is a special kind of crt1.o intended for (almost dead) sample-based userspace profiling, AKA cc -pg. This is where profiling libraries like libc_p.a were needed.

lib/csu/amd64/crt1_s.S

30

No need to add this to new files

45

Sorry, but please keep this in .c.

[dchagin]

Done, thank you

[dchagin]

lib/csu/amd64/crt1_s.S

45

whoops, Im missed that __progname is a pointer to an ampty string

[dchagin]

In D40780#927982, @kib wrote:

Please add the comments, mostly by copying/pasting the C statements for calculating each __libc_start1 arg. Also please add a comment with _start() prototype.

GCRT is the gcrt1.o compilation, it is a special kind of crt1.o intended for (almost dead) sample-based userspace profiling, AKA cc -pg. This is where profiling libraries like libc_p.a were needed.

Thank you, it looks like with GCRT test compiles and even runs,
however Im a bit confused by eprol: - seems that int3 at the end of _start in GCRT case should be avoided?

[kib]

lib/csu/amd64/crt1_s.S

45

Still, I suggest to keep crt1_c.c and have environ and __progname defined there.

53

54

Remove this blank comment line

55

Add a line with register names for args like
* %rdi %rsi

89

int3 after the __libc_start1_gcrt makes the same sense as after __libc_start1

[dchagin]

Done, Makefile a bit ugly due to source inversion

[kib]

lib/csu/amd64/crt1_s.S

36

The program entry point

55

Still not done

[kib]

Isn't stack alignment broken?

[dchagin]

Hope fixed, comment about stack added

[dchagin]

In D40780#928374, @kib wrote:

Isn't stack alignment broken?

it should not due to pushq %rbp, xregs_sig test passed

lib/csu/amd64/crt1_s.S

55

Because I add it below, before __libc_start_gcrt

[kib]

lib/csu/amd64/crt1_s.S

63

Perhaps add a comment that this does not work for large memory model.