Page MenuHomeFreeBSD

systat: Chase 70ea484e3ec5, removing vdev_cache
ClosedPublic

Authored by cy on Jun 23 2023, 10:47 PM.
Tags
None
Referenced Files
F96177100: D40742.diff
Mon, Sep 23, 11:30 PM
Unknown Object (File)
Sun, Sep 22, 1:12 AM
Unknown Object (File)
Sat, Sep 21, 4:38 PM
Unknown Object (File)
Wed, Sep 18, 12:14 AM
Unknown Object (File)
Mon, Sep 16, 11:39 PM
Unknown Object (File)
Tue, Sep 10, 10:12 AM
Unknown Object (File)
Sun, Sep 8, 10:52 AM
Unknown Object (File)
Sat, Sep 7, 5:35 AM
Subscribers
None

Details

Summary

As of 70ea484e3ec5 vdev_cache has been removed. Stop reporting on it.
Without this systat reports:

    
sysctl(kstat.zfs.misc.vdev_cache_stats.misses...) failed:
No such file or directory
Test Plan

Tested and working locally.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cy requested review of this revision.Jun 23 2023, 10:47 PM
cy created this revision.

I've never used this zarc sub-command, but looks right. May be the rest should be reviewed too, for example, due to introduction of new "iohit" state between "hit" and "miss".

This revision is now accepted and ready to land.Jun 23 2023, 10:52 PM
In D40742#926936, @mav wrote:

I've never used this zarc sub-command, but looks right. May be the rest should be reviewed too, for example, due to introduction of new "iohit" state between "hit" and "miss".

Agreed. I think iohit reporting should probably be a separate revision.

In D40742#926939, @cy wrote:

Agreed. I think iohit reporting should probably be a separate revision.

Sure. Just bringing to attention.

This revision was automatically updated to reflect the committed changes.