HomeFreeBSD

Finally drop long disabled vdev cache.

Description

Finally drop long disabled vdev cache.

It was a vdev level read cache, designed to aggregate many small
reads by speculatively issuing bigger reads instead and caching
the result. But since it has almost no idea about what is going
on with exception of ZIO_FLAG_DONT_CACHE flag set by higher layers,
it was found to make more harm than good, for which reason it was
disabled for the past 12 years. These days we have much better
instruments to enlarge the I/Os, such as speculative and prescient
prefetches, I/O scheduler, I/O aggregation etc.

Besides just the dead code removal this removes one extra mutex
lock/unlock per write inside vdev_cache_write(), not otherwise
disabled and trying to do some work.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by: iXsystems, Inc.
Closes #14953

Details

Provenance
mavAuthored on Jun 9 2023, 7:40 PM
GitHub <noreply@github.com>Committed on Jun 9 2023, 7:40 PM
Parents
rG6db4ed51d6c2: ZTS: Skip checkpoint_discard_busy
Branches
Unknown
Tags
Unknown