Page MenuHomeFreeBSD

radix_trie: pass fewer params to node_get
ClosedPublic

Authored by dougm on Jun 23 2023, 8:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 2:36 AM
Unknown Object (File)
Thu, Oct 31, 12:26 AM
Unknown Object (File)
Oct 5 2024, 7:02 AM
Unknown Object (File)
Oct 5 2024, 5:46 AM
Unknown Object (File)
Oct 2 2024, 7:18 AM
Unknown Object (File)
Oct 1 2024, 4:10 PM
Unknown Object (File)
Sep 26 2024, 9:24 PM
Unknown Object (File)
Sep 24 2024, 11:20 PM
Subscribers

Details

Summary

Let node_get calculate it's own owner value. Don't pass the count parameter, since it's always 2. Save 16 bytes in insert(). Move, without modifying, slot and trimkey to handle use-before-declaration problem.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jun 23 2023, 8:50 AM
dougm created this revision.
dougm added a reviewer: markj.

This patch needs a refresh after the trimkey patch.

markj added inline comments.
sys/kern/subr_pctrie.c
101

Perhaps remove the extra newline here since you're moving this function anyway.

This revision is now accepted and ready to land.Jun 27 2023, 2:00 PM
This revision was automatically updated to reflect the committed changes.