radix_trie: pass fewer params to node_get
ClosedPublic
Actions

Authored by dougm on Jun 23 2023, 8:50 AM.

Tags

None

Referenced Files

	F108449682: D40723.diff
	Fri, Jan 24, 9:53 PM

	Unknown Object (File)
	Tue, Jan 21, 4:54 PM

	Unknown Object (File)
	Tue, Jan 21, 8:09 AM

	Unknown Object (File)
	Fri, Jan 10, 5:33 AM

	Unknown Object (File)
	Nov 27 2024, 10:15 AM

	Unknown Object (File)
	Nov 15 2024, 6:08 AM

	Unknown Object (File)
	Nov 12 2024, 10:03 AM

	Unknown Object (File)
	Nov 8 2024, 2:36 AM

View All 52 Files

Subscribers

imp

Details

Reviewers

alc
markj

Commits

rGda72505f9c6a: radix_trie: pass fewer params to node_get

Summary

Let node_get calculate it's own owner value. Don't pass the count parameter, since it's always 2. Save 16 bytes in insert(). Move, without modifying, slot and trimkey to handle use-before-declaration problem.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm requested review of this revision.Jun 23 2023, 8:50 AM

dougm created this revision.

This patch needs a refresh after the trimkey patch.

markj accepted this revision.Jun 27 2023, 2:00 PM

markj added inline comments.

sys/kern/subr_pctrie.c
101	Perhaps remove the extra newline here since you're moving this function anyway.

This revision is now accepted and ready to land.Jun 27 2023, 2:00 PM

Closed by commit rGda72505f9c6a: radix_trie: pass fewer params to node_get (authored by dougm). · Explain WhyJun 27 2023, 5:22 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rGda72505f9c6a: radix_trie: pass fewer params to node_get.

Herald added a subscriber: imp. · View Herald TranscriptJun 27 2023, 5:22 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_pctrie.c

62 lines

vm/

vm_radix.c

59 lines

Diff 123669

View Options

sys/kern/subr_pctrie.c