Page MenuHomeFreeBSD

vm_radix: eliminate reload in _remove
ClosedPublic

Authored by dougm on Jun 22 2023, 9:42 PM.
Tags
None
Referenced Files
F102687499: D40721.diff
Fri, Nov 15, 9:25 PM
Unknown Object (File)
Sat, Oct 26, 5:43 AM
Unknown Object (File)
Oct 1 2024, 9:43 PM
Unknown Object (File)
Oct 1 2024, 12:45 PM
Unknown Object (File)
Sep 27 2024, 1:04 AM
Unknown Object (File)
Sep 25 2024, 6:12 AM
Unknown Object (File)
Sep 24 2024, 9:42 PM
Unknown Object (File)
Sep 24 2024, 12:24 PM
Subscribers

Details

Summary

In the loop that searches for the last child, load that child once, without loading it again after the search is over. Change a comparison from ">= 1" to "!= 0". The two changes reduce code size by 32 bytes on amd64.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Jun 22 2023, 9:42 PM
dougm created this revision.

Drop the broken comparison change. Now, I can only save 16 bytes.

sys/vm/vm_radix.c
782–784

Wouldn't it now make more sense to assert that tmp is not NULL?

dougm marked an inline comment as done.

Change asserts to check NULL.

sys/vm/vm_radix.c
782–784

Yes.

This revision is now accepted and ready to land.Jun 23 2023, 11:03 PM
This revision was automatically updated to reflect the committed changes.