libbsnmptools: Fully comment out set but unused count variable.
ClosedPublic
Actions

Authored by jhb on Jun 20 2023, 4:34 PM.

Details

Reviewers

syrinx
emaste

Commits

rGeca9714e4bf2: libbsnmptools: Fully comment out set but unused count variable.

Summary

These functions all end with 'return (2/* count */);'.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52205
Build 49096: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 20 2023, 4:34 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 4:34 PM

jhb requested review of this revision.Jun 20 2023, 4:34 PM

Harbormaster completed remote builds in B52205: Diff 123545.Jun 20 2023, 4:34 PM

jhb added a parent revision: D40669: iasl: Disable -Wunused-but-set-variable for a couple of files..Jun 20 2023, 4:34 PM

jhb added a child revision: D40671: jail: Mute -Wunused-but-set-variable for yynerrs..

jhb added reviewers: syrinx, emaste.Jun 20 2023, 4:43 PM

I guess...

would be nice to get upstream to do a clean up

This revision is now accepted and ready to land.Jun 20 2023, 4:56 PM

Yeah, I didn't dig in to figure out if they should be returning count or not, but this is a non-functional change at least.

Closed by commit rGeca9714e4bf2: libbsnmptools: Fully comment out set but unused count variable. (authored by jhb). · Explain WhyJun 27 2023, 5:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGeca9714e4bf2: libbsnmptools: Fully comment out set but unused count variable..

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsnmpd/

tools/

libbsnmptools/

bsnmptools.c

24 lines

Diff 123545

View Options

usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c

libbsnmptools: Fully comment out set but unused count variable.ClosedPublicActions