Page MenuHomeFreeBSD

camdd: Remove some dead code but also try to make -E functional.
ClosedPublic

Authored by jhb on Jun 20 2023, 4:34 PM.
Tags
None
Referenced Files
F115092551: D40666.id123541.diff
Sun, Apr 20, 9:46 AM
Unknown Object (File)
Fri, Apr 18, 9:38 PM
Unknown Object (File)
Thu, Apr 17, 3:54 PM
Unknown Object (File)
Wed, Apr 9, 12:46 AM
Unknown Object (File)
Feb 16 2025, 7:42 AM
Unknown Object (File)
Feb 4 2025, 7:32 AM
Unknown Object (File)
Jan 25 2025, 2:45 PM
Unknown Object (File)
Jan 17 2025, 6:26 PM
Subscribers

Details

Summary
  • Pass down the top-level arglist from main down to camdd_rw and use it in place of the hardcoded CAMDD_ARG_ERR_RECOVER when calling camdd_probe_pass. This now disables error recovery by default unless -E is specified.
  • Use the return value of parse_btl to determine if an explicit LUN was specified.
  • Remove most CAMDD_ARG_* flags that are only set and never checked. CAMDD_ARG_VERBOSE remains, but could perhaps be removed (and possibly -v should be removed as well since it is currently a no-op).

Reported by: clang -Wunused-but-set-variable (arglist in main)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable