Page MenuHomeFreeBSD

cr_canseeotheruids(9): Revamp, mark as internal
ClosedPublic

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
F102635810: D40635.diff
Fri, Nov 15, 3:35 AM
Unknown Object (File)
Sun, Nov 10, 8:44 PM
Unknown Object (File)
Thu, Nov 7, 10:09 AM
Unknown Object (File)
Wed, Nov 6, 10:13 PM
Unknown Object (File)
Wed, Nov 6, 4:47 PM
Unknown Object (File)
Tue, Nov 5, 10:25 AM
Unknown Object (File)
Tue, Nov 5, 9:54 AM
Unknown Object (File)
Fri, Nov 1, 12:19 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52347
Build 49238: arc lint + arc unit

Event Timeline

olce requested review of this revision.Jun 20 2023, 1:45 PM

For commit I think these manpage updates could be grouped into one

Thanks for these man page updates.
Have you checked them with "mandoc -Tlint" and textproc/igor for any extra warnings these tools might emit?

share/man/man9/cr_seeotheruids.9
42

You need a line break here after the sentence stop.

Change one-line description.

olce marked an inline comment as done.Jun 29 2023, 9:02 PM
In D40635#928633, @bcr wrote:

Thanks for these man page updates.
Have you checked them with "mandoc -Tlint" and textproc/igor for any extra warnings these tools might emit?

Yes, I have now.

The only warnings I've not fixed yet is for the order of references in SEE ALSO (not in this specific revision, but in some others), please see https://reviews.freebsd.org/D40632 for the rationale.

olce edited the summary of this revision. (Show Details)

Rename cr_bsd_visibility() to cr_bsd_visible().

olce retitled this revision from cr_seeotheruids(9): Revamp, mark as internal to cr_canseeotheruids(9): Revamp, mark as internal.
olce edited the summary of this revision. (Show Details)

'cr_see*' => 'cr_cansee*' (suppressed a rename in the stack).

Fix inverted description of when the policy is enabled.

My comments from D40633 apply here too.

This revision is now accepted and ready to land.Sep 27 2023, 3:33 PM
This revision was automatically updated to reflect the committed changes.