When these functions were renamed 7 years ago, their man pages were not. Rename
the latter in accordance and fix the names inside them. Fix references to them
as well. Add the old man pages to the list of obsolete files.
Details
- Reviewers
mjg kib dchagin mhorne olce - Commits
- rG29f208b78f53: cr_canseeotheruids(), cr_canseeothergids(): Man pages: Impacts of rename
rG0f353091c3f9: cr_canseeotheruids(), cr_canseeothergids(): Man pages: Impacts of rename
rGf173bbdbc1f8: cr_canseeotheruids(), cr_canseeothergids(): Man pages: Impacts of rename
rGc59ab75c04fa: cr_canseeotheruids(), cr_canseeothergids(): Man pages: Impacts of rename
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 52677 Build 49568: arc lint + arc unit
Event Timeline
I do agree that the "can" part of the name is confusing. To me, it implies a boolean return value, but in actuality a return value of zero means "yes you can".
However, many functions in kern_prot.c follow this cr_can*() or p_can*() naming convention. At this point I think it is better to keep these functions consistent with the others, and update the names of the man pages.
Yes. But I thought I would rename these despite that since they are now internal functions, in order to reserve the cr_can and p_can prefixes for functions that can actually be called from outside. But I don't mind changing the man pages instead.
What you have looks good. The only thing you are missing is to add the old names to ObsoleteFiles.inc. This ensures the old files will be cleaned up with make delete-old.