Fix TCP MD5 computation for TCP over UDP
ClosedPublic
Actions

Authored by tuexen on Jun 18 2023, 2:00 PM.

Details

Reviewers

rrs
glebius
rscheff
cc

Commits

rG081ecd9cf028: tcp: fix TCP MD5 digest computation for TCP over UDP
rG0fb0711dba76: tcp: fix TCP MD5 digest computation for TCP over UDP

Summary

The UDP header needs to be skipped similar to IPv6 extension headers.

Test Plan

Run the corresponding packetdrill tests from the setsockopt group.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Jun 18 2023, 2:00 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptJun 18 2023, 2:00 PM

tuexen requested review of this revision.Jun 18 2023, 2:00 PM

Have you checked if OpenBGPd can establish a MD5 authenticated session via TCP over UDP? Do other stacks support MD5 on TCP over UDP? (just curious).

This revision is now accepted and ready to land.Jun 19 2023, 8:41 AM

In D40596#924376, @rscheff wrote:

Have you checked if OpenBGPd can establish a MD5 authenticated session via TCP over UDP? Do other stacks support MD5 on TCP over UDP? (just curious).

I only tested with packetdrill. Not sure. if OpenBGPd support TCP over UDP. I have tested with the default, RACK and BBR stack. Not sure if other OSes support TCP over UDP. But this allows to build a TCP stack in userland...

cc accepted this revision.Jun 19 2023, 1:19 PM

Closed by commit rG0fb0711dba76: tcp: fix TCP MD5 digest computation for TCP over UDP (authored by tuexen). · Explain WhyJun 21 2023, 8:52 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG0fb0711dba76: tcp: fix TCP MD5 digest computation for TCP over UDP.

tuexen added a commit: rG081ecd9cf028: tcp: fix TCP MD5 digest computation for TCP over UDP.Jun 25 2023, 7:26 PM