bsd.mkopt.mk: Add REQUIRED_OPTIONS list
ClosedPublic
Actions

Authored by cperciva on Jun 18 2023, 12:06 AM.

Details

Reviewers: None
Commits: rGb908f6c45e02: bsd.mkopt.mk: Add REQUIRED_OPTIONS list

Summary

Options on this list will be forced to 'yes'. This is intended for use
as a transitional measure when an option is ceasing to be optional,
before all of the associated make logic is removed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52120
Build 49011: arc lint + arc unit

Event Timeline

cperciva created this revision.Jun 18 2023, 12:06 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptJun 18 2023, 12:06 AM

cperciva requested review of this revision.Jun 18 2023, 12:06 AM

Harbormaster completed remote builds in B52120: Diff 123378.Jun 18 2023, 12:06 AM

cperciva added a child revision: D40591: options/makeman: Handle __REQUIRED_OPTIONS.Jun 18 2023, 12:06 AM

imp added inline comments.Jun 18 2023, 1:08 AM

share/mk/bsd.mkopt.mk
62	Does := work multiple times?

cperciva added inline comments.Jun 18 2023, 4:16 AM

share/mk/bsd.mkopt.mk
62	I think so? But I'm not sure why it matters -- options would be moved from `__DEFAULT_YES_OPTIONS` to `__REQUIRED_OPTIONS`, not duplicated.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2023, 12:23 AM

Closed by commit rGb908f6c45e02: bsd.mkopt.mk: Add REQUIRED_OPTIONS list (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rGb908f6c45e02: bsd.mkopt.mk: Add REQUIRED_OPTIONS list.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.mkopt.mk

10 lines

src.opts.mk

5 lines

Diff 123378

View Options

share/mk/bsd.mkopt.mk