Page MenuHomeFreeBSD

options/makeman: Handle __REQUIRED_OPTIONS
ClosedPublic

Authored by cperciva on Jun 18 2023, 12:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 10, 4:36 AM
Unknown Object (File)
Sun, Sep 8, 4:10 AM
Unknown Object (File)
Sat, Sep 7, 10:50 AM
Unknown Object (File)
Sat, Sep 7, 10:35 AM
Unknown Object (File)
Sat, Sep 7, 7:54 AM
Unknown Object (File)
Thu, Sep 5, 2:49 AM
Unknown Object (File)
Sat, Aug 31, 1:37 PM
Unknown Object (File)
Sat, Aug 31, 1:37 PM
Subscribers

Details

Summary

Teach the code which generates src.conf.5 about __REQUIRED_OPTIONS;
without this change it gets confused and thinks that every option
turns the required options on.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tools/build/options/makeman
127

it might be safer to to use -V '${__REQUIRED_OPTIONS:ts,}' to get requireds and then case ",${requireds}," in *,${opt},*)

Update per suggestion from sjg

cperciva added inline comments.
tools/build/options/makeman
127

Thanks! I was trying to figure out how to do that, but I didn't realize make supported substitutions in -V arguments.

This revision is now accepted and ready to land.Jun 19 2023, 8:22 PM
This revision was automatically updated to reflect the committed changes.
cperciva marked an inline comment as done.