Not making it explicit that we're printing values in hex can be
misleading when the number doesn't contain hex-only symbols (a-f). A
good example of this is print_gp_register(), where we print "(func +
offset)"; if the offset doesn't contain a-f symbols, it's not
immediately clear if that value is in decimal or hex.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 52113 Build 49004: arc lint + arc unit
Event Timeline
Comment Actions
It doesn't print '0x' if the value is 0, and it also messes up column alignment. We could replace '0x' with '#' wherever we do not care about alignment, if you insist, however.
Comment Actions
Approved.
It doesn't print '0x' if the value is 0, and it also messes up column alignment.
I would mention this in the commit log.